Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix/Improve L0_openai_trtllm test #7948

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

krishung5
Copy link
Contributor

@krishung5 krishung5 commented Jan 17, 2025

What does the PR do?

Replaced Triton CLI usage in the test with TRTLLM tooling for less maintenance effort.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

MR 413

Where should the reviewer start?

Test plan:

  • CI Pipeline ID: 22617636

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@krishung5 krishung5 changed the title ci: Fix L0_openai_trtllm test ci: Fix/Improve L0_openai_trtllm test Jan 17, 2025
@krishung5 krishung5 requested a review from rmccorm4 January 17, 2025 22:54
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes Kris! Hopefully this test is more flexible across TRT-LLM images and less dependent on CLI updates for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants