-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add downstream tests for TrixiShallowWater.jl #1707
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1707 +/- ##
===========================================
+ Coverage 72.65% 83.05% +10.40%
===========================================
Files 431 431
Lines 34637 34665 +28
===========================================
+ Hits 25164 28791 +3627
+ Misses 9473 5874 -3599
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me - except the failing CI tests we observe also in other PRs...
Since this is not a breaking change nor affecting any tests, I suggest we go ahead and merge it to get it out of the way... |
In preparation of the upcoming Trixi.jl <--> TrixiShallowWater.jl split.