Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERK4 standalone #2147
base: main
Are you sure you want to change the base?
PERK4 standalone #2147
Changes from 5 commits
4f95871
3b84504
749a505
8ce7825
fe625ca
072693a
5266a6c
ba49773
c486b8b
cd2e868
5a30178
7ba71b0
fb21c9e
fb02916
3e23122
4cea3a9
69a1e5e
676ebac
a1df22d
42faa7a
2f8e265
7b8b166
921a3b9
5c4fce2
880aad2
6a7e244
7728de0
a7cc385
2a9d8c4
6badb45
b232eec
b29c700
283c385
c5b48a5
44f4ebe
2244572
8771f95
ddf79be
1001f65
e9c988e
1044bac
dc76fa7
28b6e2f
438d9d2
298a376
e106776
b3611aa
cdd6cb8
b9415db
47c6ea6
2ea9487
dff1ffe
3959cb8
a2f2ba4
d5eea18
1ad0d61
6da79d6
d54ef10
985dc5f
1c787df
3437831
10574df
01471d5
3bec564
3167a1b
62de7f6
88000ea
411f657
22b9a50
164794c
68cec10
926a097
5bba4cd
366b84f
40c4f09
4195f72
99f754b
c416a81
0ba9120
cb23fe6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this is restricted to
Float64
.Float32
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, since this is esssentially preprocessing I think it is okay to do this in higher precision. What needs to be revisited, though, is the datatype of the actual butcher arrays, i.e.,
Trixi.jl/src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl
Lines 137 to 138 in 62e3584