Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: see differences mhd (not a real PR --- only for my use because the merge of arr/multi-ion_mhd_2d is blocked #2203

Closed
wants to merge 97 commits into from
Closed

WIP: see differences mhd (not a real PR --- only for my use because the merge of arr/multi-ion_mhd_2d is blocked #2203

wants to merge 97 commits into from

Conversation

amrueda
Copy link
Contributor

@amrueda amrueda commented Dec 11, 2024

No description provided.

amrueda and others added 30 commits March 28, 2023 18:25
@amrueda
Started to implement the multi-ion MHD equations
ed1673e
@amrueda
Some progress with the 1D multi-ion MHD equations: First "working" ve…
e83ce8b 
…rsion with only conservative flux and estimates of wavespeeds
@amrueda
Added entropy variables
5ec8c0b
@amrueda
Added (most of) one EC flux for multi-ion MHD
bbc3a0e
@amrueda
Added non-conservative term 2 (MHD term) and tested consistency in th…
46f2500 
…e on-species case
@amrueda
Added non-conservative "term 3".. The multi-ion are EC for constant B1!
7db0931
@amrueda
Added central non-conservative "flux" for multi-ion MHD (needed for a…
f120f16 
…n LLF variant that is consistent with single species MHD)
@amrueda
Added standard source terms for the multi-ion MHD equations
b23161f
@amrueda
Added auxiliar variables and a shock-capturing example for 1D multi-i…
89ce92c 
…on MHD
@amrueda
Added multi-ion MHD equations in 2D
2b74f79
@amrueda
Added density_pressure function and double rotor test for multi-ion
7a91b6e
@amrueda
Cleaned up the multi-ion implementation a bit and added divB analysis
5dd9874
@amrueda
Removed GLM from the struct name, as GLM is not implemented for multi…
05771e8 
…-ion MHD
@sloede
Fix (most) allocations
6527aea
@amrueda @ranocha
Apply suggestions from code review (0.0 -> 0)
eac2842 
Co-authored-by: Hendrik Ranocha <[email protected]>
@amrueda
Changed all occurrences of '0.0' and 'zero(eltype(u))' to '0'
179877b
@amrueda @sloede
Apply suggestions from code review
1e0aca5 
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
@amrueda
Added set_component function
57b8ea4
@amrueda
Fixed other potential type instabilities
76325d0
@amrueda
Changed MVectors definitions to avoid creating arrays filled with zer…
8662c8f 
…o MVectors
@amrueda @sloede
Apply suggestions from code review
30636d6 
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
@amrueda
Use MVectors in cons2prim, prim2cons, and cons2entropy
968b688
@amrueda
initial_condition_weak_blast_wave (2D) uses MVector
29c5a51
@amrueda
Performance optimizations for ideal MHD multi-ion 1D
363fca2
@amrueda
Merge pull request #2 from sloede/msl/fix-allocations
cd8acb5 
Fix (most) allocations
@amrueda @sloede
Apply styling suggestions from code review
0b165ef 
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
@amrueda
Styling changes
272bdcf
@amrueda
More styling changes
e6fc017
@amrueda
Added tests for multi-ion MHD in 1D and 2D
b144498
@amrueda
Attempt to improve coverage: added new 1D test and removed density_pr…
980f7f6 
…oduct functions (not really used)
amrueda added 25 commits November 21, 2024 17:36
@amrueda
Merge pull request #14 from amrueda/multi_ion_mhd_glm
9676a8b 
Add GLM divergence cleaning to the multi-ion MHD equation
@amrueda
Merge branch 'main' into multi_ion_mhd
f044967
@amrueda
Merge branch 'main' into multi_ion_mhd
827bf4f
@amrueda
Format
d265da6
@amrueda
Merge branch 'main' into multi_ion_mhd
2527f50
@amrueda
Merge branch 'main' into multi_ion_mhd
3dc164b
@amrueda
Removed specialized divB routines for multi-ion MHD
a555e55
@amrueda
Merge branch 'main' into multi_ion_mhd
0732746
@amrueda
Added 'GLM' to the name of the 2D multi-ion MHD equations
ac54ebd
@amrueda
Improved comments for multi-ion MHD equation (2D) and renamed source_…
8c1ab2f 
…terms_standard to source_terms_lorentz
@amrueda
Merge branch 'main' into multi_ion_mhd
73c3bb6
@amrueda
Added DOI
7416798
@amrueda
Adapted 2D multi-ion MHD equations to new GLM constant update with @r…
f66eca2 
…eset
@amrueda
Cleaned up implementation of DissipationEntropyStable and improved do…
7d5c21c 
…cumentation
@amrueda
Changed the strategy to compute the non-conservative terms: use local…
fc360b3 
…*symmetric
@amrueda
Updated tests for 2D GLM-MHD multi-ion equations
0b3db84
@amrueda
Fixed typos and removed non-existing function from export
81792ee
@amrueda
Single precision compatibility
9c2f97e
@amrueda
Merge branch 'main' into multi_ion_mhd
bb3b786
@amrueda
Added 3D GLM-MHD equations with some repeated code
f58ae62
@amrueda
Improved documentation for DissipationEntropyStable
e44b52e
@amrueda
Merge branch 'arr/multi-ion_mhd_2d' into multi_ion_mhd
8cfd895
@amrueda
Moved routines that are dimension-agnostic to ideal_glm_mhd_multiion.jl
0eb9ddb
@amrueda
Improved ideal_glm_mhd_multiion_3d.jl with improvements rom the 2D PR…
099b64f 
… and removed duplicated code
@amrueda
Use a single elixir to prove EC, ES, and EC+LLF for multi-ion GLM-MHD
16bb31e
@github-actions GitHub Actions
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@amrueda amrueda marked this pull request as draft December 11, 2024 17:50
@amrueda amrueda changed the title WIP: see differences mhd WIP: see differences mhd (not a real PR --- only for my use because the merge of arr/multi-ion_mhd_2d is blocked Dec 11, 2024
@sloede sloede deleted the branch trixi-framework:arr/multi-ion_mhd_2d December 11, 2024 18:28
@sloede sloede closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrueda @sloede @ranocha