-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docstrings for flux_godunov
and flux_ec
#2219
base: main
Are you sure you want to change the base?
Docstrings for flux_godunov
and flux_ec
#2219
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2219 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 486 486
Lines 39164 39164
=======================================
Hits 37761 37761
Misses 1403 1403
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Since #2204 there is now
flux_ec
mentioned in a docstring:Trixi.jl/src/equations/numerical_fluxes.jl
Line 228 in f09a707
although such a flux is not explicitly documented. For completeness, I added the corresponding docstring for the Burgers equation.
In the same go, docstrings for
flux_godunov
are also added.