Make root device in virt instance to be configurable on creation

truenas · Jan 24, 2025 · 59d6e8a · 59d6e8a
1 parent 07c141d
commit 59d6e8a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/middlewared/middlewared/api/v25_04_0/virt_instance.py b/src/middlewared/middlewared/api/v25_04_0/virt_instance.py
@@ -81,6 +81,11 @@ class VirtInstanceCreateArgs(BaseModel):
     iso_volume: NonEmptyString | None = None
     source_type: Literal[None, 'IMAGE', 'ZVOL', 'ISO'] = 'IMAGE'
     image: Annotated[NonEmptyString, StringConstraints(max_length=200)] | None = None
+    root_disk_size: int | None = Field(ge=5, default=10)  # In GBs
+    '''
+    This can be specified when creating VMs so the root device's size can be configured. Root device for VMs
+    is a sparse zvol and the field specifies space in GBs and defaults to 10 GBs.
+    '''
     remote: REMOTE_CHOICES = 'LINUX_CONTAINERS'
     instance_type: InstanceType = 'CONTAINER'
     environment: dict[str, str] | None = None

diff --git a/src/middlewared/middlewared/plugins/virt/instance.py b/src/middlewared/middlewared/plugins/virt/instance.py
@@ -344,7 +344,14 @@ async def do_create(self, job, data):
             data['source_type'] = None
             data_devices.append(root_device_to_add)
 
-        devices = {}
+        devices = {
+            'root': {
+                'path': '/',
+                'pool': 'default',
+                'type': 'disk',
+                'size': f'{data["root_disk_size"] * (1024**3)}',
+            }
+        } if data['instance_type'] == 'VM' else {}
         for i in data_devices:
             await self.middleware.call(
                 'virt.instance.validate_device', i, 'virt_instance_create', verrors, data['instance_type'],