Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133334 / 25.10 / Only add wireguard address if wireguard interface is up #15487

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Jan 25, 2025

This commit fixes an issue where if nginx is listening to some specific IP other then wildcard and we add wireguard interface address but wireguard interface is not up (whihc happpens on boot) and this results in nginx not starting.

@sonicaj sonicaj requested a review from a team January 25, 2025 13:02
@sonicaj sonicaj self-assigned this Jan 25, 2025
@bugclerk bugclerk changed the title Only add wireguard address if wireguard interface is up NAS-133334 / 25.10 / Only add wireguard address if wireguard interface is up Jan 25, 2025
@bugclerk
Copy link
Contributor

Copy link
Contributor

@yocalebo yocalebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you wrap this in parenthesis

This commit fixes an issue where if nginx is listening to some specific IP other then wildcard and we add wireguard interface address but wireguard interface is not up (whihc happpens on boot) and this results in nginx not starting.
@sonicaj sonicaj merged commit 54e4dc3 into master Jan 25, 2025
2 checks passed
@sonicaj sonicaj deleted the NAS-133334 branch January 25, 2025 13:13
@bugclerk
Copy link
Contributor

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-133334 is targeted to the following versions which have not received their corresponding PRs: 25.04-BETA.1

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants