Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-9987: Remove the central service monitor #281

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ruivieira
Copy link
Member

See RHOAIENG-9987.

Remove the central ServiceMonitor.
With UWM, only the local (on the service's namespace) ServiceMonitor is needed.

@ruivieira ruivieira added the kind/enhancement New feature or request label Aug 27, 2024
@ruivieira ruivieira self-assigned this Aug 27, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 27, 2024

@ruivieira: This pull request references RHOAIENG-9987 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

See RHOAIENG-9987.

Remove the central ServiceMonitor.
With UWM, only the local (on the service's namespace) ServiceMonitor is needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Aug 27, 2024

@ruivieira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e d14d828 link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ruivieira ruivieira marked this pull request as draft August 27, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants