Nang changes

[nang-dev]

---

Important

Rename 'Secondary Side Bar' to 'PearAI Side Bar' across the codebase and update PearAI submodule.

• Renaming:
  • Rename 'Secondary Side Bar' to 'PearAI Side Bar' in viewsExtensionPoint.ts, layoutActions.ts, layout.ts, auxiliaryBarActions.ts, auxiliaryBarPart.ts, auxiliaryTitleBar.ts, paneCompositeBar.ts, panelActions.ts, workbench.contribution.ts, and viewQuickAccess.ts.
• Scripts:
  • Comment out PearAI submodule recompilation in code.sh to speed up the build process.
• Submodule Update:
  • Update pearai-submodule to commit 4cdbc4f3dd0280bb4e401ae5ffe9a04d25f22a59.

^{This description was created by for 13a25fe. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 13a25fe in 1 minute and 11 seconds

More details

• Looked at 346 lines of code in 12 files
• Skipped 0 files when reviewing.
• Skipped posting 12 drafted comments based on config settings.

1. src/vs/workbench/contrib/quickaccess/browser/viewQuickAccess.ts:52

• Draft comment:
  The fuzzy filtering logic looks clear. Consider caching or memoizing the generated pick items, especially if the list of views is long, to prevent performance issues on repeated invocations.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. src/vs/workbench/contrib/quickaccess/browser/viewQuickAccess.ts:67

• Draft comment:
  Separator labels combine the container label with the parent label. Verify that the mapping logic using mapEntryToContainer correctly handles cases when container labels are similar – consider adding unit tests to ensure correct grouping.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. src/vs/workbench/contrib/quickaccess/browser/viewQuickAccess.ts:118

• Draft comment:
  The function 'doGetViewPickItems' aggregates view entries across pane composites and terminals effectively. Consider invalidating the cache when the view service state changes to account for asynchronous updates.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. src/vs/workbench/contrib/quickaccess/browser/viewQuickAccess.ts:156

• Draft comment:
  Overall, the quick access provider implementation is clean with clear separation of concerns. No obvious logical bugs detected.
• Reason this comment was not posted:
  Comment did not seem useful.

5. src/vs/workbench/contrib/quickaccess/browser/viewQuickAccess.ts:256

• Draft comment:
  Ensure that all keybindings and localization strings are updated consistently with the new branding (e.g., 'PearAI Side Bar'). They appear consistent in this file, but a review is recommended.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

6. src/vs/workbench/contrib/quickaccess/browser/viewQuickAccess.ts:391

• Draft comment:
  For actions that move views between panels and the PearAI Side Bar, verify that all labels and in-code comments have been updated to reflect the new 'PearAI' branding. There is a typo ('loaction') that should be corrected consistently.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

7. src/vs/workbench/contrib/quickaccess/browser/viewQuickAccess.ts:240

• Draft comment:
  The OpenViewPickerAction and QuickAccessViewPickerAction classes are straightforward. Consider whether additional user feedback (such as loading indicators) is needed when there is any delay in computing the picks, although it may not be necessary.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

8. src/vs/workbench/browser/parts/paneCompositeBar.ts:207

• Draft comment:
  Composite bar actions in the pane composite bar seem robust. Ensure that the creation and disposal of composite actions is efficient and that the cached state is properly maintained, especially after extension registrations.
• Reason this comment was not posted:
  Comment did not seem useful.

9. src/vs/workbench/browser/parts/auxiliarybar/auxiliaryTitleBar.ts:32

• Draft comment:
  The AuxiliaryTitleBar renders icons based on a fixed array. Consider future-proofing by externalizing the icon definitions or using constants, especially if these icons may become dynamic in the future.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

10. src/vs/workbench/browser/workbench.contribution.ts:29

• Draft comment:
  The workbench configuration registration is extensive. Double-check that the markdown descriptions reference updated labels consistently, especially with changes like 'PearAI Side Bar', to ensure uniform branding.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

11. panelActions.ts:392

• Draft comment:
  Typo: "default loaction" should be "default location" in the comment for MovePearExtensionToAuxBarAction.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

12. panelActions.ts:388

• Draft comment:
  For consistency with renaming the secondary side bar to 'PearAI Side Bar', update the label in MovePearExtensionToAuxBarAction from 'Move Pear Extension to Auxiliary Bar' to 'Move Pear Extension to PearAI Side Bar'.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_ca9JOUvWyfGtfSxj

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.