Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added go.mod support, fixed a bug and made a simple addition #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

karanveersp
Copy link

Hi,
This library is really cool and useful so I wanted to understand how it worked. While reading the source, I was able to make some general refactors such as:

  • Adding go.mod support
  • Replacing interface{} with any which is an alias to interface{}.
  • Fixing a bug where err was being returned instead of innerErr.
  • Adding a public function GetApplicationDirPath which returns the path to platform-dependent application configuration directory. This is useful if the user of the library wants to manipulate it and needs easy access to that parent folder of the config for deleting it, or backing it up somewhere, etc.

I updated the test to use GetApplicationDirPath to verify it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant