Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create functions for grasp compute #1024

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Create functions for grasp compute #1024

wants to merge 3 commits into from

Conversation

alberth
Copy link
Contributor

@alberth alberth commented Mar 14, 2020

Deduplicate assigning position and orientation in the grasp computation.

@alberth alberth requested a review from jlunenburg March 23, 2020 15:41
@alberth alberth mentioned this pull request Mar 23, 2020
Open
LarsJanssenTUe
LarsJanssenTUe approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@LarsJanssenTUe LarsJanssenTUe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it is tested this looks good to me!

@alberth alberth mentioned this pull request Mar 31, 2020
Open
@alberth
Copy link
Contributor Author

alberth commented Mar 31, 2020

Actually, it is not tested and I don't know how to do that, as in all these years, nobody has managed to explain to me what I need to install to get the simulator running without magic tue-something command.
We can have another attempt at that.

@LoyVanBeek
Copy link
Member

Actually, it is not tested and I don't know how to do that, as in all these years, nobody has managed to explain to me what I need to install to get the simulator running without magic tue-something command.

@MatthijsBurgh can you help @alberth with this?

@LarsJanssenTUe
Copy link
Contributor

@alberth @MatthijsBurgh I assume that @alberth does not have a simulator yet right? @alberth I could test these PR's for you, but that does not solve anything in the long run, so I suggest you get the simulator. I know that it is possible to do it without running the 'magic tue-something command', however this would probably be a pain (hence the reason for this magical command), so my question would be: why not use this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LarsJanssenTUe LarsJanssenTUe LarsJanssenTUe approved these changes

@jlunenburg jlunenburg Awaiting requested review from jlunenburg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alberth @LoyVanBeek @LarsJanssenTUe