refactor : 함수 파라미터 final 추가

- 함수 파라미터에 final 추가 Open #12
tukcomCD2024 · Jan 11, 2024 · de81002 · de81002
1 parent 585b2ef
commit de81002
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 12 deletions.
diff --git a/...nd/core/src/main/java/site/timecapsulearchive/core/domain/auth/api/AuthApiController.java b/...nd/core/src/main/java/site/timecapsulearchive/core/domain/auth/api/AuthApiController.java
@@ -29,7 +29,7 @@ public ResponseEntity<TemporaryTokenResponse> getOAuth2GooglePage() {
 
     @Override
     public ResponseEntity<TokenResponse> reIssueAccessToken(
-        @RequestBody TokenReIssueRequest request) {
+        @RequestBody final TokenReIssueRequest request) {
         return ResponseEntity.ok(tokenService.reIssueToken(request.refreshToken()));
     }
 

diff --git a/...n/java/site/timecapsulearchive/core/domain/auth/repository/MemberInfoCacheRepository.java b/...n/java/site/timecapsulearchive/core/domain/auth/repository/MemberInfoCacheRepository.java
@@ -18,10 +18,14 @@ public class MemberInfoCacheRepository {
 
     /**
      * 키와 {@code memberInfo}를 받아서 캐시에 저장
-     * @param key 캐시에 저장할 키, UUID string
+     *
+     * @param key        캐시에 저장할 키, UUID string
      * @param memberInfo 저장할 사용자 정보
      */
-    public void save(String key, MemberInfo memberInfo) {
+    public void save(
+        final String key,
+        final MemberInfo memberInfo
+    ) {
         redisTemplate.opsForValue().set(
             PREFIX + key,
             memberInfo,
@@ -32,19 +36,24 @@ public void save(String key, MemberInfo memberInfo) {
 
     /**
      * 사용자 정보 조회
+     *
      * @param infoKey 캐시에 저장된 키, UUID string
      * @return {@code Optional<MemberInfo>} 사용자 정보
      */
-    public Optional<MemberInfo> getMemberInfo(String infoKey) {
+    public Optional<MemberInfo> getMemberInfo(final String infoKey) {
         return Optional.ofNullable(redisTemplate.opsForValue().get(PREFIX + infoKey));
     }
 
     /**
      * 삭제 로직 대신 키의 이름을 변경, O(1) 소요
+     *
      * @param oldKey 이전 키
      * @param newKey 새로운 키
      */
-    public void rename(String oldKey, String newKey) {
+    public void rename(
+        final String oldKey,
+        final String newKey
+    ) {
         redisTemplate.rename(PREFIX + oldKey, PREFIX + newKey);
     }
 }
diff --git a/...end/core/src/main/java/site/timecapsulearchive/core/domain/auth/service/TokenService.java b/...end/core/src/main/java/site/timecapsulearchive/core/domain/auth/service/TokenService.java
@@ -27,14 +27,14 @@ public class TokenService {
      * @param memberId 액세스 토큰 클레임 값에 넣을 사용자 아이디
      * @return 토큰 응답(액세스 토큰, 리프레시 토큰, 액세스 토큰 만료일, 리프레시 토큰 만료일)
      */
-    public TokenResponse createNewToken(Long memberId) {
+    public TokenResponse createNewToken(final Long memberId) {
         String key = String.valueOf(UUID.randomUUID());
         memberInfoCacheRepository.save(key, new MemberInfo(memberId));
 
         return createTokenResponse(memberId, key);
     }
 
-    private TokenResponse createTokenResponse(Long memberId, String key) {
+    private TokenResponse createTokenResponse(final Long memberId, final String key) {
         return TokenResponse.create(
             jwtFactory.createAccessToken(memberId),
             jwtFactory.createRefreshToken(key),
@@ -49,7 +49,7 @@ private TokenResponse createTokenResponse(Long memberId, String key) {
      * @param memberId 임시 인증 토큰 클레임 값에 사용할 사용자 아이디
      * @return 임시 인증 토큰 응답(임시 인증 토큰, 임시 인증 토큰 만료일)
      */
-    public TemporaryTokenResponse createTemporaryToken(Long memberId) {
+    public TemporaryTokenResponse createTemporaryToken(final Long memberId) {
         return TemporaryTokenResponse.create(
             jwtFactory.createTemporaryAccessToken(memberId),
             jwtFactory.getTemporaryTokenExpiresIn()
@@ -62,7 +62,8 @@ public TemporaryTokenResponse createTemporaryToken(Long memberId) {
      * @param refreshToken 리프레시 토큰
      * @return 토큰 응답(액세스 토큰, 리프레시 토큰, 액세스 토큰 만료일, 리프레시 토큰 만료일)
      */
-    public TokenResponse reIssueToken(String refreshToken) throws AlreadyReIssuedTokenException {
+    public TokenResponse reIssueToken(final String refreshToken)
+        throws AlreadyReIssuedTokenException {
         String oldKey = jwtFactory.getClaimValue(refreshToken, MEMBER_INFO_KEY);
         MemberInfo memberInfo = memberInfoCacheRepository.getMemberInfo(oldKey)
             .orElseThrow(AlreadyReIssuedTokenException::new);

diff --git a/backend/core/src/main/java/site/timecapsulearchive/core/global/security/jwt/JwtFactory.java b/backend/core/src/main/java/site/timecapsulearchive/core/global/security/jwt/JwtFactory.java
@@ -36,7 +36,7 @@ public JwtFactory(JwtProperties jwtProperties) {
      * @param memberId 사용자 아이디
      * @return 액세스 토큰
      */
-    public String createAccessToken(Long memberId) {
+    public String createAccessToken(final Long memberId) {
         Date now = new Date();
         Date validity = new Date(now.getTime() + accessTokenValidityMs);
 
@@ -53,7 +53,7 @@ public String createAccessToken(Long memberId) {
      * @param memberProfileKey 사용자 식별자
      * @return 리프레시 토큰
      */
-    public String createRefreshToken(String memberProfileKey) {
+    public String createRefreshToken(final String memberProfileKey) {
         Date now = new Date();
         Date validity = new Date(now.getTime() + refreshTokenValidityMs);
 
@@ -70,7 +70,7 @@ public String createRefreshToken(String memberProfileKey) {
      * @param memberId 사용자 아이디
      * @return 리프레시 토큰
      */
-    public String createTemporaryAccessToken(Long memberId) {
+    public String createTemporaryAccessToken(final Long memberId) {
         Date now = new Date();
         Date validity = new Date(now.getTime() + temporaryValidityMs);