Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arch 22 feat/social login #25

Merged
merged 45 commits into from
Jan 12, 2024
Merged

Arch 22 feat/social login #25

merged 45 commits into from
Jan 12, 2024

Conversation

GaBaljaintheroom
Copy link
Collaborator

작업 내용 (Content)

  • 카카오 소셜 로그인 기능 추가
  • 구글 소셜 로그인 기능 추가
  • Member 엔티티 수정
  • flyway 문서 추가

링크 (Links)

기타 사항 (Etc)

  • 구글 로그인 scope는 profile, image이고 kakao 로그인은 profile_image, account_email, 닉네임도 있어서 Member 엔티티에 닉네임을 어떻게 저장해야 할지에 대해 -> 일단 구글과 카카오의 scope를 이메일과, 프로필 이미지로 맞추고 닉네임은 전화번호 인증 후 업데이트를 하는 방식으로 생각함
  • 소셜 로그인 맡은 부분을 알맞게 구현을 한건지 의문

Merge 전 필요 작업 (Checklist before merge)

  • config application-local.yml 수정

희망 리뷰 완료 일 (Expected due date)

202X. X. X. Wed

@GaBaljaintheroom
chore : OAuth 라이브러리 추가
bfbd02d
@GaBaljaintheroom
refact : member 엔티티 수정
b816280
@GaBaljaintheroom
feat : 사용자 역할 속성 추가
159c55d
@GaBaljaintheroom
feat : 사용자 소셜 타입 추가
e3c1e80
@GaBaljaintheroom
feat : OAuth 로그인 서비스 작성
71ddab0
@GaBaljaintheroom
feat : OAuth2UserInfo 생성
0673767
@GaBaljaintheroom
feat : 카카오 OAuth2UserInfo 생성
b6fe3a1
@GaBaljaintheroom
feat : 구글 OAuth2UserInfo 생성
347e1aa
@GaBaljaintheroom
feat : OAuthAttributes 작성
ad002ca
@GaBaljaintheroom
feat : CustomOAuth2User 생성
1a9308f 
- 반환할 사용자 정보
@GaBaljaintheroom
feat : SecurityConfig에 oauth2Login 추가
f880081
@GaBaljaintheroom
feat : MemberRepository 메서드 추가
4599f92
@GaBaljaintheroom
feat : OAuthToEntity 메서드 작성
4c6ed22 
- OAuth로부터 가져온 데이터를 Member 엔티티로 변경
@GaBaljaintheroom
docs : flyway Member 엔티티 수정 사항 작성
587f601 
- oauth2_provider를 social_type으로 변경
- role 속성 추가
@GaBaljaintheroom
chore : local.yml 수정
e7f8b22
@GaBaljaintheroom GaBaljaintheroom self-assigned this Jan 10, 2024
@GaBaljaintheroom GaBaljaintheroom added the feat 새로운 기능 label Jan 10, 2024
@seokho-1116
Copy link
Collaborator

OAuth2 url을 주는 엔드포인트도 만들어야 할듯?

@seokho-1116
Copy link
Collaborator

OAuth2용 Spring filter chain을 하나 붙여야 할듯

@seokho-1116
Copy link
Collaborator

OAuth2AuthorizationRequestRedirectFilter 관련해서 리서치

@GaBaljaintheroom
feat : SocialOauthUri 인테페이스 작성
73c5dd9
@GaBaljaintheroom
feat : GoogleOauthUri 생성
d6a713c
@GaBaljaintheroom
feat : KakaoOauthUri 생성
c2a7cfb
@GaBaljaintheroom
feat : auth Controller 작성
dc26b22
@GaBaljaintheroom
chore : application-local.yml 수정
2a80aa3
@GaBaljaintheroom
fix : 머지 충돌 해결
2c29e26
@GaBaljaintheroom
refact : CustomOAuth2User id 추가
7965151
@GaBaljaintheroom
refact : CustomOAuth2UserService id 추가
b10a903
@GaBaljaintheroom
feat : 에러 코드 추가
1450c72
@GaBaljaintheroom
refact : 실패 로그 추가
0088f58
@GaBaljaintheroom
refact : oauth 인증 실패 수정
d721e00
@GaBaljaintheroom
refact : oauth 성공 핸들러 수정
82c7d77
@GaBaljaintheroom
feat : OAuthUrlResponse 생성
8f89e48
@GaBaljaintheroom
feat : OAuthDsl 생성
109a4a5
@GaBaljaintheroom
feat : CommonSecurityDsl 생성
5e78c5e
@GaBaljaintheroom
refact : AuthController 수정
46f8f9b
@GaBaljaintheroom
feat : lombok.config 생성
a166993
@GaBaljaintheroom
refact : SecurityConfig 수정
04dd0f5
@GaBaljaintheroom
refact : AuthApi 수정
03c070f
@GaBaljaintheroom
refact : application-local.yml 수정
bfe64e7
seokho-1116
seokho-1116 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@seokho-1116 seokho-1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿

backend/core/src/main/java/site/timecapsulearchive/core/domain/auth/entity/Role.java Outdated Show resolved Hide resolved
.../src/main/java/site/timecapsulearchive/core/domain/auth/service/CustomOAuth2UserService.java Show resolved Hide resolved
.../src/main/java/site/timecapsulearchive/core/domain/auth/service/CustomOAuth2UserService.java Outdated Show resolved Hide resolved
backend/core/src/main/java/site/timecapsulearchive/core/domain/member/entity/Member.java Outdated Show resolved Hide resolved
@seokho-1116 seokho-1116 merged commit 6baca9f into develop_back Jan 12, 2024
2 checks passed
@seokho-1116 seokho-1116 deleted the ARCH-22-feat/social_login branch January 25, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-1116 seokho-1116 seokho-1116 approved these changes

Assignees

@GaBaljaintheroom GaBaljaintheroom

Labels
feat 새로운 기능
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GaBaljaintheroom @seokho-1116