Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: general audit issues #116

Merged
merged 7 commits into from
Jul 30, 2024
Merged

fix: general audit issues #116

merged 7 commits into from
Jul 30, 2024

Conversation

LaurenzSommerlad
Copy link
Member

  • Fixed general minor audit issues like missing alt texts for images & logos and broken links
  • Small wording changes in venture descriptions
  • Replaced generic "learn more" with project names according to site audit report:

image

@LaurenzSommerlad LaurenzSommerlad added the Ready for merge Developer wants this PR to be merged label Jul 27, 2024
@LaurenzSommerlad LaurenzSommerlad requested a review from Cyro292 July 27, 2024 23:30
@LaurenzSommerlad LaurenzSommerlad self-assigned this Jul 27, 2024
Copy link

vercel bot commented Jul 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
website ✅ Ready (Inspect) Visit Preview Jul 30, 2024 0:14am

@LaurenzSommerlad LaurenzSommerlad changed the title bug: general audit issues fix: general audit issues Jul 27, 2024
@Cyro292
Copy link
Contributor

Cyro292 commented Jul 28, 2024

At first glance, it appeared to me that the cards on our site are different sizes. However they are not and this illusion might be created by the varying sizes of the pictures and the resulting placement of the headers.

To address this, we should consider implementing a black/white/transparent picture background with a fixed size for each card ensuring that the header is always at the same hight. This should help maintain visual consistency and avoid any illusions of differing card sizes.

@LaurenzSommerlad
Copy link
Member Author

good idea @Cyro292, changed the image ratio for now to align with the rest. Let's keep this in mind for the future!

Copy link
Contributor

@Cyro292 Cyro292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cyro292 Cyro292 merged commit 2b2e760 into develop Jul 30, 2024
3 checks passed
@Cyro292 Cyro292 deleted the bug/general-audit-issues branch July 30, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for merge Developer wants this PR to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants