Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new social media preview elab and banner for final pitch event #96

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

timonschramm
Copy link
Contributor

URL ist currently my own, as one needs are absolute URL
Please suggest where else we have such a filestore for Photos that are not directly rendered but need a link, google drive? :) https://timonschramm.com/sm-preview.jpg

Also much more important is the banner for Final Pitch since we need to have some signups in the next time :)

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 11:15am

@marinamomina
Copy link

  1. Do we need this? Looks like it is there by accident
    image

  2. Image looks pixelated
    image

  3. Is kinda far away from everything else
    image

4.Rewrite text maybe, 2 times "and" in one sentence, and "evening when " instead of "evening where"
image

  1. Image in the last Item of Carousel is damaged
    image

  2. Poor photo quality
    image

  3. Carousel items are to tall to fit on a 15 inch screen, we can leave like that but I think it will look better if everything(photo, text, team logo) will fit on a screen
    image

  4. I think it should be centered
    image

  5. Probs should be updated
    image
    image

@timonschramm
Copy link
Contributor Author

timonschramm commented Dec 14, 2023

Thanks for the Feedback!
2,3 Are regarding Tally, might look into that later as well with 6 & 7.

resolved 1,4,5,8,9 for now

@timonschramm timonschramm merged commit 3741d74 into develop Dec 15, 2023
5 checks passed
@timonschramm timonschramm deleted the fix-new-social-media-preview-elab branch December 15, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants