fix code

tumugin · Apr 7, 2022 · c06b022 · c06b022
1 parent f491901
commit c06b022
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 28 deletions.
diff --git a/src/SnNumeric.php b/src/SnNumeric.php
@@ -63,10 +63,8 @@ public function toFloat(): float
      */
     public function isEqual($value): bool
     {
-        if (is_int($value) || is_float($value)) {
-            return $this->value === $value;
-        }
-        return $this->value === $value->value;
+        $rawValue = is_int($value) || is_float($value) ? $value : $value->value;
+        return $this->value === $rawValue;
     }
 
     /**
@@ -76,10 +74,8 @@ public function isEqual($value): bool
      */
     public function isGreaterOrEqualThan($value): bool
     {
-        if (is_int($value) || is_float($value)) {
-            return $this->value === $value;
-        }
-        return $this->value >= $value->value;
+        $rawValue = is_int($value) || is_float($value) ? $value : $value->value;
+        return $this->value >= $rawValue;
     }
 
     /**
@@ -89,10 +85,8 @@ public function isGreaterOrEqualThan($value): bool
      */
     public function isGreaterThan($value): bool
     {
-        if (is_int($value) || is_float($value)) {
-            return $this->value === $value;
-        }
-        return $this->value > $value->value;
+        $rawValue = is_int($value) || is_float($value) ? $value : $value->value;
+        return $this->value > $rawValue;
     }
 
     /**
@@ -102,10 +96,8 @@ public function isGreaterThan($value): bool
      */
     public function isLessOrEqualThan($value): bool
     {
-        if (is_int($value) || is_float($value)) {
-            return $this->value === $value;
-        }
-        return $this->value <= $value->value;
+        $rawValue = is_int($value) || is_float($value) ? $value : $value->value;
+        return $this->value <= $rawValue;
     }
 
     /**
@@ -115,10 +107,8 @@ public function isLessOrEqualThan($value): bool
      */
     public function isLessThan($value): bool
     {
-        if (is_int($value) || is_float($value)) {
-            return $this->value === $value;
-        }
-        return $this->value < $value->value;
+        $rawValue = is_int($value) || is_float($value) ? $value : $value->value;
+        return $this->value < $rawValue;
     }
 
     /**

diff --git a/src/SnString.php b/src/SnString.php
@@ -94,10 +94,8 @@ public function length(): SnInteger
      */
     public function equals($value): bool
     {
-        if (is_string($value)) {
-            return $this->value === $value;
-        }
-        return $this->value === $value->value;
+        $rawValue = is_string($value) ? $value : $value->value;
+        return $this->value === $rawValue;
     }
 
     /**
@@ -108,10 +106,8 @@ public function equals($value): bool
      */
     public function concat($value)
     {
-        if (is_string($value)) {
-            return new static($this->value . $value);
-        }
-        return new static($this->value . $value->value);
+        $rawValue = is_string($value) ? $value : $value->value;
+        return new static($this->value . $rawValue);
     }
 
     /**