Allow more valid characters for prom label #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels, capital letters are valid as the first character. This allows parsing something like https://github.com/NVIDIA/dcgm-exporter
didn't realize 0.1.10 was on hex already
joaothallis
reviewed
Sep 1, 2024
Co-authored-by: João Thallis <[email protected]>
joaothallis
reviewed
Sep 1, 2024
| @@ -4,7 +4,7 @@ defmodule PrometheusParser.MixProject do | |||
| def project do | |||
| [ | |||
| app: :prometheus_parser, | |||
| version: "0.1.9", | |||
| version: "0.1.11", | |||
There was a problem hiding this comment.
Suggested change
| version: "0.1.11", | |
| version: "0.1.10", |
There was a problem hiding this comment.
There is actually a 0.1.10 on hex already, which is why I went up to 0.1.11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels, capital letters are valid as the first character. This allows parsing something like https://github.com/NVIDIA/dcgm-exporter.
This is not actually a complete fix for parsing, since metric names and metric labels have a slightly different form, but this fixes an issue someone on slack was having with this package.