Aggregated stats for queries with most elapsed_time #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athoscouto
changed the title
athoscouto
force-pushed
the
athos/stats
branch
from
9e934b1 to
ae3b433
Compare
|
|
LucioFranco
reviewed
Feb 27, 2024
athoscouto
force-pushed
the
athos/stats
branch
from
756109b to
161ce1e
Compare
athoscouto
force-pushed
the
athos/stats
branch
from
161ce1e to
e8893c1
Compare
|
@LucioFranco it looks like my background worker is making tests hang. |
LucioFranco
approved these changes
Feb 28, 2024
* Record query latency percentiles with hdrhistogram * Expose queries percentiles through stats response * Simplify QueriesStats transformation to QueriesStatsResponse * Reset query stats at the beginning of every hour (#1118) * Add expires_at to control when QueriesStats should be reset * Add query count and elapsed sum to query stats response Also group all latency aggregations together under the elapsed key * Remove option sprawl on QueriesStats fields By making the whole struct optional where it is used * Add created_at to stats queries responde object * Set queries stats to none when stats is created This will make the API response the same when no queries have been recorded on the queries stats struct. This can happen right after: - the stats struct initialization - the stats queries object expiration Example of stats API response when no queries have been recorded: { ... "queries": null } * Use if else instead of early return from stats to response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to provide statistics about an individual query.
This is the first step, adding
count,elapsed_ms,rows_written, androws_read.Those stats are not persisted on purpose, since we want them to be ephemeral and even reset from time to time.