schema migration #1110
Merged
schema migration #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
schema-migration
branch
7 times, most recently
from
e258feb to
162fbd9
Compare
Horusiath
reviewed
Mar 4, 2024
libsql-server/src/database/schema.rs
Outdated
| .await?; | ||
| self.connection | ||
| .execute_program(pgm, ctx, response_builder, replication_index) | ||
| dbg!(); |
| 3 => Self::Run, | ||
| 4 => Self::Success, | ||
| 5 => Self::Failure, | ||
| _ => panic!(), |
There was a problem hiding this comment.
Suggested change
| _ => panic!(), | |
| _ => unreachable!(), |
| 3 => Self::WaitingRun, | ||
| 4 => Self::RunSuccess, | ||
| 5 => Self::RunFailure, | ||
| _ => panic!(), |
There was a problem hiding this comment.
Suggested change
| _ => panic!(), | |
| _ => unreachable!(), |
| builder: B, | ||
| ) -> (Result<B, Error>, MigrationTaskStatus) { | ||
| // todo error handling is sketchy, improve | ||
| let mut savepoint = conn.savepoint().unwrap(); |
There was a problem hiding this comment.
I guess this is also a place for bottomless savepoint (see #1085) in order to guarantee, that in case of crashes we can restore db to a state where the dry run succeeded. However in a current API it operates on the Database type not a Connection.
There was a problem hiding this comment.
let's discuss that
MarinPostma
force-pushed
the
schema-migration
branch
from
162fbd9 to
1c06866
Compare
haaawk
approved these changes
Mar 4, 2024
MarinPostma
force-pushed
the
schema-migration
branch
from
1c06866 to
23838ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements the happy path of schema migration. do not use this feature yet.
TODO:
include!that file for clarityenqueued_tasksis updated corectly after a task is popped when a tasks status changed (maybe use a trigger?)