libsql-sqlite3: Export more API functions in Wasm #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need the `sqlite3_get_autocomit()` helper in the TypeScript SDK, for example. The fact that it's not exported seems to be just an omission so let's add it.
penberg
force-pushed
the
penberg/wasm-autocommit
branch
from
fc9e36b to
566434c
Compare
psarna
approved these changes
Jan 11, 2024
penberg
force-pushed
the
penberg/wasm-autocommit
branch
from
fe4699a to
12cab8a
Compare
penberg
changed the title
|
@penberg let's promote it from draft to PR? It's perfectly safe and makes sense, if we need more symbols later we'll just add them |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the
sqlite3_get_autocomit()andsqlite_last_insert_rowid()in the TypeScript SDK, for example. The fact that it's not exported seems to be just an omission so let's add it.