Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindings/java: Change logger dependency #863

Merged
merged 2 commits into from
Feb 3, 2025
Merged

bindings/java: Change logger dependency #863

merged 2 commits into from
Feb 3, 2025

Conversation

seonWKim
Copy link
Contributor

@seonWKim seonWKim commented Feb 2, 2025 •
edited
Loading

The purpose of this PR

  • Current implementation forces users to use logback as their logging framework

Changes

  • Only add abstraction layer for loggin(which is slf4j in this case)
  • In tests, use logback to log out messages(this doesn't affect the users)

References

#615

@seonWKim seonWKim marked this pull request as draft February 2, 2025 03:58
@seonWKim seonWKim changed the title bindings/java: Fix debugger to print out INFO messages by default bindings/java: Change logger dependency Feb 2, 2025
@seonWKim seonWKim marked this pull request as ready for review February 2, 2025 04:02
@penberg penberg merged commit fc5f2c7 into tursodatabase:main Feb 3, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seonWKim @penberg