Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship libsql-server with Turso CLI #9

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

avinassh
Copy link
Member

@avinassh avinassh commented Dec 13, 2023

Fixes TURSO-125

@avinassh avinassh force-pushed the sqld branch 2 times, most recently from e8bd3a6 to e6bf0e1 Compare December 14, 2023 13:49
@avinassh avinassh marked this pull request as ready for review December 15, 2023 06:49
@avinassh
Copy link
Member Author

avinassh commented Jan 2, 2024

Changed this PR to draft. Currently stopped because of this bug: tursodatabase/libsql#793 Otherwise homebrew linux installations will be inconsistent.

Once the linked bug is fixed, then Homebrew formula of CLI can be updated to ship with sqld. Along with we can merge the current PR too.

@avinassh avinassh marked this pull request as draft January 2, 2024 09:40
@avinassh avinassh marked this pull request as ready for review January 11, 2024 15:22
@avinassh
Copy link
Member Author

Homebrew formula is now fixed and we can merge this!

@avinassh avinassh requested review from penberg and haaawk January 11, 2024 15:24
@haaawk haaawk merged commit 7b0b499 into tursodatabase:main Feb 7, 2024
2 checks passed
@avinassh avinassh deleted the sqld branch February 7, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants