Merge pull request #251 from tusharmath/update-deps-0

chore(package): update dependencies

.travis.yml

@@ -1,5 +1,6 @@
 language: node_js
 cache:
+  yarn: true
   directories:
     - ~/.npm
     - node_modules
@@ -8,8 +9,8 @@ notifications:
 node_js:
   - stable
 before_script:
-   - npm run coverage
-   - npm run lint
+   - yarn coverage
+   - yarn lint
 after_success:
   - npm run travis-deploy-once "npm run semantic-release"
 branches:

package.json

@@ -10,7 +10,7 @@
     "coverage": "nyc npm test && nyc report --reporter=text-lcov | coveralls",
     "hydra": "node --trace-hydrogen --trace-phase=Z --trace-deopt --code-comments --hydrogen-track-positions --redirect-code-traces --redirect-code-traces-to=code.asm ./benchmarks/run",
     "prepublish": "tsc -d && npm run build",
-    "test": "tsc && mocha",
+    "test": "tsc && mocha --reporter=min",
     "test:watch": "mocha --watch",
     "build": "rollup -c ./config/rollup.config.js",
     "lint": "git ls-files | grep '.ts$' | xargs tslint",
@@ -23,27 +23,27 @@
   "license": "ISC",
   "devDependencies": {
     "@types/benchmark": "^1.0.30",
-    "@types/mocha": "^5.0.0",
-    "@types/node": "^9.3.0",
+    "@types/mocha": "^5.2.0",
+    "@types/node": "^10.0.0",
     "benchmark": "^2.1.2",
     "cli-table2": "^0.2.0",
-    "coveralls": "^3.0.0",
+    "coveralls": "^3.0.1",
     "cz-conventional-changelog": "^2.0.0",
-    "ghooks": "^2.0.0",
-    "mocha": "^5.0.0",
-    "nyc": "^11.0.3",
-    "prettier": "^1.11.1",
+    "ghooks": "^2.0.4",
+    "mocha": "^5.1.1",
+    "nyc": "^11.7.1",
+    "prettier": "^1.12.1",
     "prettify": "^0.1.7",
     "request-promise": "^4.1.1",
-    "rollup": "^0.57.1",
+    "rollup": "^0.58.0",
     "rollup-plugin-babili": "^3.0.0",
-    "rollup-plugin-commonjs": "^9.1.0",
+    "rollup-plugin-commonjs": "^9.1.3",
     "rollup-plugin-uglify": "^3.0.0",
-    "semantic-release": "^15.1.2",
-    "travis-deploy-once": "^4.3.0",
-    "ts-node": "5.0.1",
-    "tslint": "^5.3.2",
-    "typescript": "^2.0.3",
+    "semantic-release": "^15.3.1",
+    "travis-deploy-once": "^5.0.0",
+    "ts-node": "^6.0.0",
+    "tslint": "^5.10.0",
+    "typescript": "^2.8.3",
     "uglify": "^0.1.5",
     "validate-commit-msg": "^2.8.2"
   },

src/sinks/ToNodeStream.ts

@@ -1,7 +1,7 @@
 /**
  * Created by tushar on 29/10/17.
  */
-import {Transform, Writable} from 'stream'
+import {Transform, TransformCallback, Writable} from 'stream'
 import {IObservable} from '../internal/Observable'
 import {IObserver} from '../internal/Observer'
 import {ISubscription} from '../internal/Subscription'
@@ -36,12 +36,8 @@ class ToNodeStream extends Transform {
     this.sub.unsubscribe()
   }
 
-  _transform(
-    chunk: any,
-    encoding: any,
-    callback: (err: Error | null, value: any) => void
-  ) {
-    callback(null, chunk)
+  _transform(chunk: any, encoding: string, callback: TransformCallback) {
+    callback(undefined, chunk)
   }
 }
 

test/test.ForEach.ts

@@ -20,16 +20,16 @@ describe('forEach()', () => {
     })
     it('should unsubscribe from the source on error', () => {
       const sh = createTestScheduler()
-      const expected = '^---!'
       const testObservable = sh.Hot('-123#')
+      const expected = '             ^---!'
       assert.throws(
         () =>
           sh.startSubscription(() => forEach(() => void 0, testObservable, sh)),
-        '#'
+        (_: Error) => _.message === '#'
       )
 
       const actual = testObservable.toString()
-      assert.strictEqual(actual, expected)
+      assert.strictEqual(actual, expected.trim())
     })
   })