update liboqs to version 0.12.0 and use ml-kem instead of kyber #8440
+230
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaf-hub
force-pushed
the
crypto/update-liboqs-1956
branch
from
94e9b88 to
de632d5
Compare
charlag
approved these changes
Jan 31, 2025
vaf-hub
force-pushed
the
crypto/update-liboqs-1956
branch
2 times, most recently
from
584543f to
57c908c
Compare
kyber will be dropped with the next release we need to apply our hack to turn ml-kem into kyber for backward compatibility. this requires some extra kdf and hash step to bind the key to the ciphertext. we do not want to pull additional dependencies in typescript and liboqs already comes with shake and sha3, so we just do this in C. we apply a patch to remove fprintf calls from the compiledd liboqs code to not depend on stdio for wasm build #tutadb1956
vaf-hub
force-pushed
the
crypto/update-liboqs-1956
branch
from
57c908c to
e393084
Compare
charlag
reviewed
Feb 3, 2025
|
|
||
| console.log("Building dev for", app) | ||
|
|
||
| if (clean) { | ||
| await runStep("Clean", async () => { | ||
| await fs.emptyDir(buildDir) | ||
| await fs.rm(liboqsIncludeDir, { recursive: true, force: true }) |
There was a problem hiding this comment.
this will cause make to bulid every time if I understand it right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kyber will be dropped with the next release
we need to apply our hack to turn ml-kem into kyber for backward compatibility. this requires some extra kdf and hash step to bind the key to the ciphertext.
we do not want to pull additional dependencies in typescript and liboqs already comes with shake and sha3, so we just do this in C.
we apply a patch to remove fprintf calls from the compiledd liboqs code to not depend on stdio for wasm build
#tutadb1956