Fix "Interface langugage not fully switching to newly selected language" #8457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibibytium
force-pushed
the
fix-templates-translation
branch
from
9ca4a65 to
36e84d1
Compare
The issue when switching languages was caused by saving the translated string together with data. We switched SettingsFolder name to a lazy string again. Another issue was caused by not handling UserSettingsGroupRoot updates. Fix #8391 Co-authored-by: Kinan <[email protected]> Co-authored-by: sug <[email protected]> Co-authored-by: ivk <[email protected]>
kibibytium
force-pushed
the
fix-templates-translation
branch
from
36e84d1 to
3c07f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use TranslationKeys for template
folder names in SettingsView when
possible.