Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update manual and examples with latest pattern features #1924

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

yannham
Copy link
Member

@yannham yannham commented May 21, 2024

Closes #1911.

This PR updates the manual to take into account the latest extensions of pattern matching, namely wildcard patterns, constant patterns, array patterns, pattern guards and or-patterns.

Doing so, we also update the examples (in the manual and in the examples directory) to use pattern matching whenever it looks more idiomatic and make the code more readable.

@yannham yannham force-pushed the doc/update-pattern-section branch from 6d8e9db to e4abda6 Compare May 27, 2024 10:02
@github-actions github-actions bot temporarily deployed to pull request May 27, 2024 10:05 Inactive
@yannham yannham requested a review from jneem May 27, 2024 10:11
@yannham yannham marked this pull request as ready for review May 27, 2024 10:11
@github-actions github-actions bot temporarily deployed to pull request May 27, 2024 10:14 Inactive
@yannham
Copy link
Member Author

yannham commented May 27, 2024

Note that this PR requires to update Topiary to handle all of this new syntax first. Currently the Nickel formatting task of the CI chokes on those new constructs.

doc/manual/syntax.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request May 29, 2024 16:28 Inactive
@yannham yannham added this to the Next Minor (1.7) milestone Jun 4, 2024
@yannham yannham force-pushed the doc/update-pattern-section branch from 4961e74 to d2d9ec6 Compare June 7, 2024 08:17
@yannham yannham enabled auto-merge June 7, 2024 08:17
@github-actions github-actions bot temporarily deployed to pull request June 7, 2024 08:20 Inactive
This commit update the manual to take into account the latest extensions
of pattern matching, namely wildcard patterns, constant patterns, array
patterns, pattern guards and or-patterns.

Doing so, we also update the examples (in the manual and in the
`examples` directory) to use pattern matching whenever it looks more
idiomatic and make the code more readable.

Co-authored-by: jneem <[email protected]>
@yannham yannham force-pushed the doc/update-pattern-section branch from d2d9ec6 to c7bbed2 Compare June 7, 2024 08:36
@github-actions github-actions bot temporarily deployed to pull request June 7, 2024 08:38 Inactive
@yannham yannham added this pull request to the merge queue Jun 7, 2024
Merged via the queue into master with commit 519c022 Jun 7, 2024
5 checks passed
@yannham yannham deleted the doc/update-pattern-section branch June 7, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation for new pattern features
2 participants