pass thru feature nix-experimental
#2132
Merged
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneem
reviewed
Dec 24, 2024
|
Bencher Report| Branch | import-nix |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| fibonacci 10 | 📈 view plot 🚷 view threshold | 486.14 |
| foldl arrays 50 | 📈 view plot 🚷 view threshold | 1,675.80 |
| foldl arrays 500 | 📈 view plot 🚷 view threshold | 6,710.60 |
| foldr strings 50 | 📈 view plot 🚷 view threshold | 6,999.70 |
| foldr strings 500 | 📈 view plot 🚷 view threshold | 61,076.00 |
| generate normal 250 | 📈 view plot 🚷 view threshold | 43,971.00 |
| generate normal 50 | 📈 view plot 🚷 view threshold | 2,013.30 |
| generate normal unchecked 1000 | 📈 view plot 🚷 view threshold | 3,342.80 |
| generate normal unchecked 200 | 📈 view plot 🚷 view threshold | 759.07 |
| pidigits 100 | 📈 view plot 🚷 view threshold | 3,108.80 |
| pipe normal 20 | 📈 view plot 🚷 view threshold | 1,487.30 |
| pipe normal 200 | 📈 view plot 🚷 view threshold | 9,829.50 |
| product 30 | 📈 view plot 🚷 view threshold | 829.71 |
| scalar 10 | 📈 view plot 🚷 view threshold | 1,524.50 |
| sum 30 | 📈 view plot 🚷 view threshold | 815.65 |
KiaraGrouwstra
force-pushed
the
import-nix
branch
from
6cad1cf to
58c8137
Compare
jneem
approved these changes
Dec 26, 2024
|
once there's a new release i'll file the corresponding PR at nixpkgs as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the
nickelpackage in nixpkgs had yet to add support for nickel'snix-experimentalfeature flag.in an in-progress attempt to add this, i bumped into a few hurdles for this on the nickel side.
this PR tries to address these, on the Cargo side erring toward passing thru the feature for a few extra packages for consistency.
whereas i'm not sure this would be sufficient on the nickel side (yet having to get it to work at run-time), i felt maybe i could get a bit of feedback on this direction already.