Dont check in the grammar, but generate it at release time #2145
+42
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2141, that avoids checking in a 22MB generated file. Here, we generate the grammar at
cargo publish
time. The main disadvantage of this one is that it's hard to test: although I've tested the individual commands, I haven't tested the release script as a whole because I didn't want to push changes to thestable
branch.I've simplified the build script so that it doesn't try to check the freshness of the generated grammar: it assumes that if there's a generated grammar already present then it's fresh. In principle the published crate could have an even simpler build process (with no build-dependency on lalrpop) but that would introduce more hard-to-test release stuff so I haven't gone that route.