Optimize compiled code for "set" tag #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Sep 24, 2024
stof
reviewed
Sep 24, 2024
fabpot
force-pushed
the
set-node-optimization
branch
2 times, most recently
from
be3a491 to
f40624c
Compare
stof
reviewed
Sep 24, 2024
fabpot
force-pushed
the
set-node-optimization
branch
from
f40624c to
9855e35
Compare
stof
reviewed
Sep 24, 2024
| @@ -33,9 +33,15 @@ public function __construct(bool $capture, Node $names, Node $values, int $linen | |||
| $safe = false; | |||
| if ($capture) { | |||
| $safe = true; | |||
| if ($values instanceof TextNode) { | |||
| if (Node::class === get_class($values) && !count($values)) { | |||
There was a problem hiding this comment.
See this makes me think we should really investigate having a dedicated node class for representing a statement list in 4.x (as suggested in #4292 (comment)), as we have this special case of Node::class === get_class($values) in more and more places
stof
approved these changes
Sep 24, 2024
fabpot
added a commit
that referenced
this pull request
Sep 27, 2024
…ode and Nodes (fabpot) This PR was merged into the 3.x branch. Discussion ---------- Deprecate instantiating Node directly, introduce EmptyNode and Nodes Based on some comments from `@stof`: See #4292 (comment) See #4333 (comment) First interesting usage here: 65ee72a Commits ------- 8b27898 Deprecate using Node directly, introduce EmptyNode and Nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.