-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert to scala 2.12.9 and ignore MiMa false positives #682
Conversation
@@ -151,6 +151,56 @@ lazy val noPublishSettings = Seq( | |||
publishArtifact := false | |||
) | |||
|
|||
// https://github.com/lightbend/mima/issues/388 | |||
lazy val mimaSettings = Def.settings( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not pretty but I guess we will be able to remove this once that issue is fixed
@regadas This seems fine to get things green for a release, but I think we should revert it after the next publish. What do you think? |
@johnynek sounds good! 👍 |
flaky |
I'll rerun but : Maybe tut isn't compatible with one of these version bumps? maybe an sbt caching bug? |
Oh! I missed that! I'll have a look. |
Maybe we should revert the 2.12 bump. Master is red now and it caused all the scala steward bumps to fail. |
Yup agreed! yesterday I tracked this a bit and I think there's something fishy around
|
Codecov Report
@@ Coverage Diff @@
## develop #682 +/- ##
===========================================
+ Coverage 89.5% 89.58% +0.08%
===========================================
Files 112 112
Lines 8943 8943
Branches 314 314
===========================================
+ Hits 8004 8012 +8
+ Misses 939 931 -8
Continue to review full report at Codecov.
|
See for more context: lightbend-labs/mima#388