Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to scala 2.12.9 and ignore MiMa false positives #682

Merged
merged 2 commits into from
Sep 20, 2019

Conversation

regadas
Copy link
Collaborator

@regadas regadas commented Sep 18, 2019

See for more context: lightbend-labs/mima#388

@@ -151,6 +151,56 @@ lazy val noPublishSettings = Seq(
publishArtifact := false
)

// https://github.com/lightbend/mima/issues/388
lazy val mimaSettings = Def.settings(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not pretty but I guess we will be able to remove this once that issue is fixed

@johnynek
Copy link
Collaborator

@regadas This seems fine to get things green for a release, but I think we should revert it after the next publish. What do you think?

@regadas
Copy link
Collaborator Author

regadas commented Sep 18, 2019

@johnynek sounds good! 👍

@regadas
Copy link
Collaborator Author

regadas commented Sep 18, 2019

flaky tut?

@johnynek
Copy link
Collaborator

I'll rerun but :(run-main-0) java.lang.NoSuchMethodError: scala.reflect.internal.util.ReusableInstance.<init>(Lscala/Function0;)V doesn't look flakey. It looks like binary incompatibility.

Maybe tut isn't compatible with one of these version bumps?

maybe an sbt caching bug?

@regadas
Copy link
Collaborator Author

regadas commented Sep 18, 2019

Oh! I missed that! I'll have a look.

@johnynek
Copy link
Collaborator

Maybe we should revert the 2.12 bump. Master is red now and it caused all the scala steward bumps to fail.

@regadas
Copy link
Collaborator Author

regadas commented Sep 19, 2019

Yup agreed! yesterday I tracked this a bit and I think there's something fishy around tut and 2.12.10 repl interpreter that it's instantiated; seems that the classpath is not right.

2.12.9 is ok I'll push a commit here to double check.

@codecov-io
Copy link

Codecov Report

Merging #682 into develop will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #682      +/-   ##
===========================================
+ Coverage     89.5%   89.58%   +0.08%     
===========================================
  Files          112      112              
  Lines         8943     8943              
  Branches       314      314              
===========================================
+ Hits          8004     8012       +8     
+ Misses         939      931       -8
Impacted Files Coverage Δ
.../main/scala/com/twitter/algebird/Successible.scala 87.5% <0%> (-4.17%) ⬇️
.../main/scala/com/twitter/algebird/BloomFilter.scala 93.8% <0%> (-0.45%) ⬇️
.../main/scala/com/twitter/algebird/Approximate.scala 90.32% <0%> (+1.61%) ⬆️
...main/scala/com/twitter/algebird/monad/Reader.scala 55.55% <0%> (+5.55%) ⬆️
...src/main/scala/com/twitter/algebird/Interval.scala 85.21% <0%> (+6.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5d501...298bc59. Read the comment docs.

@regadas regadas changed the title Fix: ignore MiMa false positives Revert to scala 2.12.9 and ignore MiMa false positives Sep 19, 2019
@nevillelyh nevillelyh merged commit ebab2a2 into twitter:develop Sep 20, 2019
@nevillelyh nevillelyh mentioned this pull request Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants