Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fs2-data-csv, fs2-data-csv-generic to 1.11.0 #158

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

typelevel-steward[bot]
Copy link
Contributor

About this PR

πŸ“¦ Updates

from 1.10.0 to 1.11.0

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.gnieh" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.gnieh" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

@TonioGela
Copy link
Member

@Mergifyio rebase please

Copy link
Contributor

mergify bot commented Mar 29, 2024

rebase please

βœ… Branch has been successfully rebased

@TonioGela TonioGela force-pushed the update/fs2-data-csv-1.11.0 branch from 6e1e624 to 5b08c87 Compare March 29, 2024 19:54
@TonioGela
Copy link
Member

@armanbilge apparently fs2-data-csv for scala.js was compiled with scala.js 1.16 and so is no more supported by default by scala-cli (unless specifing a specific scala.js version). What do you think it's wiser doing? Should we "pin" this dep or encourage scala-cli users to use scala.js 1.14+ ?

@typelevel-steward typelevel-steward bot force-pushed the update/fs2-data-csv-1.11.0 branch from 5b08c87 to ff759a0 Compare March 29, 2024 20:08
@armanbilge
Copy link
Member

scala.js 1.16 and so is no more supported by default by scala-cli

Mm, are you sure? The release notes for scala-cli v1.2.1 say they support Scala.js 1.16.0. Unless for some reason they added support without making it the default?

https://github.com/VirtusLab/scala-cli/releases/tag/v1.2.1

@armanbilge armanbilge closed this Mar 31, 2024
@armanbilge armanbilge reopened this Mar 31, 2024
@armanbilge
Copy link
Member

The problem is not related to scala-cli.

The problem is that we have not updated Scala.js in our own build. I am sending out the Steward updates now.

addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.15.0")

@armanbilge armanbilge closed this Mar 31, 2024
@armanbilge armanbilge reopened this Mar 31, 2024
@armanbilge armanbilge merged commit 4fb18f0 into main Mar 31, 2024
17 of 29 checks passed
@armanbilge armanbilge deleted the update/fs2-data-csv-1.11.0 branch March 31, 2024 16:49
@TonioGela
Copy link
Member

The problem is not related to scala-cli.

The problem is that we have not updated Scala.js in our own build. I am sending out the Steward updates now.

addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.15.0")

Thanks Arman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants