Update sbt-scalajs, scalajs-compiler, ... to 1.17.0

[typelevel-steward]

About this PR

📦 Updates

• org.scala-js:sbt-scalajs
• org.scala-js:scalajs-compiler
• org.scala-js:scalajs-library
• org.scala-js:scalajs-library_2.13
• org.scala-js:scalajs-test-bridge
• org.scala-js:scalajs-test-bridge_2.13

from 1.16.0 to 1.17.0

📜 GitHub Release Notes - Version Diff

Usage

✅ Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-js" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-js" }
}]

^{labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1}

[TonioGela]

To the best of my understanding this fails because we're stuck to scala-cli 1.4.0, that defaults to 1.16.0 as scala-js version:

$ scala-cli --cli-version 1.4.0 --help-js
Usage: default [options]

Scala.js options:
  --js-version string?                   The Scala.js version (1.16.0 by default).
...

As a countermeasure (locally works, I've tried it) I can add buildInfoKeys += "jsVersion" -> scalaJSVersion in build.sbt and specify the js version in the tests header as we did with native

val header = BuildInfo.platform match {
  case "jvm" => commonHeader
  case "js" =>
-    commonHeader
+    commonHeader :+
+      s"//> using jsVersion ${BuildInfo.jsVersion}"
  case "native" =>
    commonHeader :+
      s"//> using nativeVersion ${BuildInfo.nativeVersion}"
}

WDYT @armanbilge?

[armanbilge]

because we're stuck to scala-cli 1.4.0

Sorry, remind me why we are stuck?

[TonioGela]

because we're stuck to scala-cli 1.4.0

Sorry, remind me why we are stuck?

Yeah, why? We shouldn't be. I guess I did something bad closing and reopening this, as steward didn't propose any version bump for cli. I'll check at its logs, but I don't recall if there's a way to unstuck it.

[TonioGela]

I'll check at its logs

It reports org.virtuslab.scala-cli:(cli, cli_3) : 1.4.0 -> 1.4.3 as the only update found and that's the PR I/we've mangled a bit. I wonder if forcing 1.5.4 manually will trigger a virtuous circle again.

1.5.4 fixes (see here) as the linking error as it picks sjs 1.17.0 by default)

[armanbilge]

Yes, let's just go to 1.5.4. We are supposed to be testing against the latest scala-cli anyway :)

[TonioGela]

@Mergifyio rebase please

[mergify]

rebase please

✅ Branch has been successfully rebased