"Kinds" #117
Merged
"Kinds" #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK. If I've done this correctly, the only thing that should break are the bifunctor instances (which nobody is using anyways). @typelift/fp We good to go? |
|
This is looking good to me, although I'm a little worried we're locking ourselves into this kind of thing even if higher kinds someday become available. Maybe not, though. |
|
Don't worry, I promise to revert everything to structs and protocols the second they give us parametrizable protocols (:pray:). That's what this is trying to emulate anyhow. |
|
I'm gonna give this 24 hours more. Speak now or forever hold your peace. |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, not really, but you do get sensible parametrization in protocols. Also marks quite a few classes final.
May be topical wrt #1 and #45