Skip to content

Commit

Permalink
added Laravel 5.6 to list of Laravel acceptable versions
Browse files Browse the repository at this point in the history
  • Loading branch information
@bmw27
bmw27 committed Feb 12, 2018
1 parent 2512580 commit 01d4975
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"require": {
"illuminate/support": "5.*",
"mrclay/shibalike": "1.0.0",
"laravel/framework": "5.4.* || 5.5.*",
"laravel/framework": "5.4.* || 5.5.* || 5.6.*",
"tymon/jwt-auth": "^0.5.10"
},
"autoload": {
Expand Down

4 comments on commit 01d4975

@jpuck
Copy link

@jpuck jpuck commented on 01d4975 Apr 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmw27 are you using this in a production system running 5.6? I'm hoping this patch is all that's needed for razorbacks#11

@bmw27
Copy link
Member Author

@bmw27 bmw27 commented on 01d4975 Apr 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we don't have this in production yet. We don't even have the 5.4/5.5 version there yet because of the way our server is currently configured. I want to test it out next week though so I'll get back to you after that on how it does with 5.6.

@jpuck
Copy link

@jpuck jpuck commented on 01d4975 Apr 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I no longer work for the University, and subsequently have no access to a productive Shib environment. But I had no issues upgrading from 5.4 -> 5.5, so I suspect it might be ready for 5.6 also (I only blocked it in composer.json just in case it was breaking). I wouldn't mind making a new release if that's all that needs to be changed, but again I have no way to test it.

@bmw27
Copy link
Member Author

@bmw27 bmw27 commented on 01d4975 Apr 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, hope you're on to bigger and better things! I'll let you know how the composer.json version update works so you can make a new release. By the way, thanks for the work you did on laravel-shibboleth. Seems like it'll be really nice once I finally get the time to implement it.

Please sign in to comment.