Skip to content
This repository has been archived by the owner on Sep 25, 2020. It is now read-only.

Add lookupn.N timing stat #71

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add lookupn.N timing stat #71

wants to merge 3 commits into from

Conversation

motiejus
Copy link
Contributor

@motiejus motiejus commented Jun 8, 2016 •
edited
Loading

We do not have lookupn.N stat, need to add it. Related PRs:

@motiejus motiejus mentioned this pull request Jun 8, 2016
Merged
@mennopruijssers
Copy link
Contributor

LGTM, make sure to change lookupN to lookupn in the PR/commit message when merging as well.

mennopruijssers
mennopruijssers reviewed Jun 8, 2016
View reviewed changes
docs/running_ringpop.md
@@ -76,6 +76,7 @@ that Ringpop emits:
|join.retries|Number of retries required by join process|gauge
|join.succeeded|Join process succeeded|count
|lookup|Time required to perform a ring lookup|timer
|lookupn.N|Time required to perform a ring lookupN with for a preference list of N nodes|timer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"with for"?

@motiejus motiejus changed the title Add lookupN.N timing stat Add lookupn.N timing stat Jun 8, 2016
@thanodnl
Copy link
Contributor

thanodnl commented Jun 9, 2016

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@motiejus @mennopruijssers @thanodnl