This repository has been archived by the owner on Sep 25, 2020. It is now read-only.
Add integration tests for identities #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mennopruijssers
commented
Dec 14, 2016
mennopruijssers
commented
- Add support to specify the identity of the sut (required new version of testpop)
- Extracted full hashring mapping to it's own method for reuse
- add identity tests
mennopruijssers
commented
Dec 14, 2016
| return dsl.assertLookup(t, tc, replicaPoint, hostPort); | ||
| }); | ||
| }); | ||
| return dsl.assertFullHashring(t, tc); |
There was a problem hiding this comment.
This is extracted so it can be re-used by the identity tests.
mennopruijssers
commented
Dec 14, 2016
| @@ -428,7 +428,13 @@ function callEndpoint(t, tc, endpoint, body, validateEvent) { | |||
| */ | |||
| function assertLookup(t, tc, key, expected) { | |||
| return [ | |||
| callEndpoint(t, tc, '/admin/lookup', {key: key}), | |||
| callEndpoint(t, tc, '/admin/lookup', {key: key}, function validate(body) { | |||
There was a problem hiding this comment.
By adding the validate-callback we fail earlier; without it we fail by timeout.
mennopruijssers
changed the base branch from
feature/allow-initial-labels
to
master
added 5 commits
December 15, 2016 16:19
mennopruijssers
force-pushed
the
feature/identity
branch
from
b6593f8 to
fa784f1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.