Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to h3 v4.2.0 #198

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Upgrade to h3 v4.2.0 #198

wants to merge 5 commits into from

Conversation

isaacbrodsky
Copy link
Collaborator

@isaacbrodsky isaacbrodsky commented Dec 13, 2024 •
edited
Loading

I was a bit surprised to find I needed to relax tests about edgeLength here. Did something change there?

  • The tests for polygonToCellsExperimental are admittedly not very comprehensive. We should test other modes as well.

@coveralls
Copy link

coveralls commented Dec 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12322254200

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 99.571%
Totals Coverage Status
Change from base Build 11645004319: 0.02%
Covered Lines: 574
Relevant Lines: 575
💛 - Coveralls

@isaacbrodsky isaacbrodsky marked this pull request as ready for review December 13, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrabinowitz nrabinowitz Awaiting requested review from nrabinowitz

@dfellis dfellis Awaiting requested review from dfellis

@ajfriend ajfriend Awaiting requested review from ajfriend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isaacbrodsky @coveralls