-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom reward token to permit #17
feat: add custom reward token to permit #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests passing and looks good
also afaik it doesn't break any other plugins
This should not break any plugin since plugins will use a specific version of the package, meaning they won't be using it with the changes here, unless we update the version within their |
Co-authored-by: Mentlegen <[email protected]>
@rndquu fine with the content. I just think you might want to amend the commit to change |
As far I understand the changes introduced in this PR touch only the |
Related to #16
This PR adds support for custom ERC20 token address in permits. So instead of hardcoding ERC20 reward token address partners will have to set it manually.
How it is expected to work:
conversation-rewards
plugin similar to:conversation-rewards
plugin here ERC20 reward token address will be read from the config and passed in permit requestsNotice:
1.2.2
to1.2.3
although ideally it should be bumped to2.0.0
since backwards compatibility for the generatePayoutPermit() is broken