feat: decode metamask transaction error #353
Conversation
|
|
QA:
|
|
Looks good. Idk if it's worth it to also log the onchain function name that was called too using the 4byte api .. @rndquu rfc I think if we can make this robust and re-useable @ariesgun then we can open a task and implement it in |
There was a problem hiding this comment.
This QA has some drawbacks:
- Result is shown in the console instead of a toaster
- Error is not in a human readable way
Expected behavior: user sees a toaster with a human friendly error instead of a hex string.
Pls use https://github.com/superical/ethers-decode-error/tree/1.x, I'm sure we can simply fork it and set node version to <20.
It should be made clear in the spec. |
|
|
Unused dependencies (1)
Unlisted dependencies (2)
|
|
For now, waiting for the ubiquite-hosted npm package for |
|
I opened a PR on that regard here: https://github.com/ubiquity/ethers-decode-error/pull/1 |
|
I suppose all crypto related software should be under ubiquity org. |
|
@ariesgun, this task has been idle for a while. Please provide an update. |
|
Still ongoing |
|
@ariesgun, this task has been idle for a while. Please provide an update. |
|
I published it under @rndquu You can delete this repo: https://github.com/ubiquity/ethers-decode-error thank you. |
The crypto related stuff should be under @ubiquity |
|
@0x4007 Please move it because I have no access and the NPM token under |
|
That's right we might not have access to the ubiquity npm for some reason. @rndquu im mobile but do you have access? Can you solve for this |
|
Is there anything I can do to help close this one? |
|
@rndquu @gentlementlegen lets finalize this |
@0x4007 would need the token to be updated in order to publish to the proper NPM organization. |
rndquu
requested review from
rndquu
and removed request for
Keyrxng and
rndquu
|
As far as I understand everything is fine right now:
|
|
@0x4007 , can you please take a look at this PR? If everything is okay, appreciate if you can approve it. Thanks. |
|
@ariesgun, this task has been idle for a while. Please provide an update. |
|
Still waiting for approval |
|
@rndquu if you can delete https://github.com/ubiquity/ethers-decode-error I do not have permissions to do so, thanks. |
|
Archive might be better? |
|
I already archived it, but it is a duplicate of the one located in the other organization so I thought it'd be better to delete to avoid confusion. |
Resolves #346