feat: empty string warning

[Keyrxng]

Resolves #31

• Identifies empty strings and posts a comment onto the pull request
• updates that comment when changes are made
• removes it once all are fixed

QA: ubq-testing/bot-ai#31

[github-actions]

Lines	Statements	Branches	Functions
	80% (4/5)	100% (0/0)	66.66% (2/3)

JUnit

Tests	Skipped	Failures	Errors	Time
1	0 💤	0 ❌	0 🔥	2.692s ⏱️

Coverage Report (80%)

File	% Stmts	% Branch	% Funcs	% Lines	Uncovered Line #s
All files	80	100	66.66	80
main.ts	80	100	66.66	80	9

[Keyrxng]

This was a mistake, meant to open it against my own dev branch and I don't have the option to close as unplanned lmao

[gentlementlegen]

@Keyrxng Just use this pull request as the final one, I converted it to a draft in the meantime.

[Keyrxng]

@FernandVEYRIER ready when you are mate

[ubiquity-os-deployer]

af57518

a61d62d

cdae93a

[Keyrxng]

• Update page.tsx ubq-testing/bot-ai#33 (review)

• PR review comment for empty string

• Only empty strings added as part of the PR are commented on (pre-existing cannot be commented on)

[0x4007]

You forgot about double back tick ``

[Keyrxng]

fucksake I wish I had seen this earlier but as I said before, me and bash not so great but I'm no quitter 😂

Took me way longer than I wanted it to, it's not 100% perfect neither but it's ~90-95% accurate (my shortcomings relating to bash scripting is the reason why I haven't got it 100%, scripting syntax and sanitization proving tough trying to capture every variation I could (.tsx being the main point of failure re: {""} but in tsx terms that's common syntax so I wasn't sure to even capture that but I did anyway)

• add empty strings ubq-testing/bot-ai#46

• seeing as it's a commit comment it's tied to each commit so if "" is used in commit 1 and not resolved in commit 2 then commit 3 will retain the comment symbol but will not receive a comment as the change happened two commits ago, only once "" are removed will the comment symbol disappear. (the 2nd last commit is proof of this, having an comment symbol but no actual comment)

• it's diffed from incoming commit > most recent, the reason why is because if "" is used in commit 1 and unresolved in commit 2 then every single commit following will receive a comment (spamming if there are multiple) but it won't be tied to any file because the change is in commit 1 so it's just clutter and noise)

• As for implementing an ignore switch, the wf runs on a push to PR so, it only checks for empty strings that are being pushed into the PR not ones that existed prior (unless edited). Disabling prior to running would be .env or secret based wouldn't it on a per repo basis? I can't think of how to disable it any other way of the top of my head

[rndquu]

@Keyrxng Check this PR and this commit that assigns js variables empty strings.

The expected behaviour is that Empty string annotations should've been added, right?

[Keyrxng]

strange

it's identified the empty strings and their location and the GitHub UI is showing two comments but the comments are nowhere to be seen... any ideas why that might be off the top of your head? I'll see if I can debug the issue. I see it missed the one in static/main all together.

[rndquu]

any ideas why that might be off the top of your head?

Hard to say what went wrong