Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add dune dashboard link #969

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

YanVictorSN
Copy link
Contributor

Resolves #965

@YanVictorSN YanVictorSN requested a review from rndquu as a code owner October 2, 2024 02:48
@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Oct 2, 2024

@YanVictorSN YanVictorSN changed the title docs: add dunedashboard link docs: add dune dashboard link Oct 2, 2024
README.md Outdated Show resolved Hide resolved
@rndquu
Copy link
Member

rndquu commented Oct 2, 2024

@YanVictorSN Hey, a few questions:

  1. Is it possible to transfer the dashboard ownership to the ubiquity_dao team?
  2. How often is the dashboard updated? I mean do we need to update it manually or dune automatically updates it once in a while?
  3. The lusd-collateral-information table in dashboard is missing these properties from this method. Is it possible to display all of them?
  4. Some of the queries are private (like total_amount_lusd_collateral_pool, I'm getting the 404 Page Not Found or Private error). Could you make all of the queries public? I want to understand how everything is calculated.

@0x4007
Copy link
Member

0x4007 commented Oct 2, 2024

@YanVictorSN Hey, a few questions:

  1. Is it possible to transfer the dashboard ownership to the ubiquity_os team?

I prefer https://dune.com/ubiquity_dao @rndquu I made you admin

@YanVictorSN
Copy link
Contributor Author

@YanVictorSN Hey, a few questions:

  1. Is it possible to transfer the dashboard ownership to the ubiquity_dao team?
  2. How often is the dashboard updated? I mean do we need to update it manually or dune automatically updates it once in a while?
  3. The lusd-collateral-information table in dashboard is missing these properties from this method. Is it possible to display all of them?
  4. Some of the queries are private (like total_amount_lusd_collateral_pool, I'm getting the 404 Page Not Found or Private error). Could you make all of the queries public? I want to understand how everything is calculated.
  1. Yes, it's possible. We need to create a team on Dune and then I can transfer the dashboard and queries.
  2. It's possible to schedule them to run automatically (by minute, hour, day, or week). Running all queries right now would cost us 90 credits and we have 2,700 available per month.
  3. I see. I think it's possible if I change how I call the query. Dune can't directly access functions or variables only data that triggers an on-chain action like an event. But we can use an API to call the function internally. I'll work on that.
  4. Sure. I didn't want to expose the API key so I made it private. I'll remove it now.

@YanVictorSN
Copy link
Contributor Author

@YanVictorSN Hey, a few questions:

  1. Is it possible to transfer the dashboard ownership to the ubiquity_os team?

I prefer https://dune.com/ubiquity_dao @rndquu I made you admin

@0x4007 can you add me to the Ubiquity DAO team so I can share the dune dashboard? @yanvictoreth

@YanVictorSN
Copy link
Contributor Author

YanVictorSN commented Oct 3, 2024

3. The lusd-collateral-information table in dashboard is missing these properties from this method. Is it possible to display all of them?

@rndquu

Manage to get 3 more infos:
1- collateralAddress
2- poolStorage.collateralPriceFeedAddresses
3- poolStorage.collateralPriceFeedStalenessThresholds

Working on the others.

@rndquu
Copy link
Member

rndquu commented Oct 4, 2024

@YanVictorSN Hey, a few questions:

  1. Is it possible to transfer the dashboard ownership to the ubiquity_os team?

I prefer https://dune.com/ubiquity_dao @rndquu I made you admin

@0x4007 can you add me to the Ubiquity DAO team so I can share the dune dashboard? @yanvictoreth

Done, I suppose the "Editor" role has enough permissions to transfer the dashboard

@YanVictorSN
Copy link
Contributor Author

@YanVictorSN Hey, a few questions:

  1. Is it possible to transfer the dashboard ownership to the ubiquity_os team?

I prefer https://dune.com/ubiquity_dao @rndquu I made you admin

@0x4007 can you add me to the Ubiquity DAO team so I can share the dune dashboard? @yanvictoreth

Done, I suppose the "Editor" role has enough permissions to transfer the dashboard

It worked. I just transferred the ownership. Thanks.

@rndquu rndquu marked this pull request as draft October 4, 2024 10:42
@rndquu
Copy link
Member

rndquu commented Oct 4, 2024

@YanVictorSN Hey, a few questions:

  1. Is it possible to transfer the dashboard ownership to the ubiquity_os team?

I prefer https://dune.com/ubiquity_dao @rndquu I made you admin

@0x4007 can you add me to the Ubiquity DAO team so I can share the dune dashboard? @yanvictoreth

Done, I suppose the "Editor" role has enough permissions to transfer the dashboard

It worked. I just transferred the ownership. Thanks.

Pls mark the PR as "ready for review" once you're done with the dashboard

@YanVictorSN
Copy link
Contributor Author

YanVictorSN commented Oct 7, 2024

  1. The lusd-collateral-information table in dashboard is missing these properties from this method. Is it possible to display all of them?

@rndquu It's done. We have displayed all the lusd colleteral information.

@YanVictorSN YanVictorSN marked this pull request as ready for review October 7, 2024 17:37
@0x4007 0x4007 requested review from rndquu and removed request for rndquu October 14, 2024 16:56
@YanVictorSN
Copy link
Contributor Author

hi @rndquu any update on this task?

Copy link

ubiquity-os bot commented Nov 4, 2024

@YanVictorSN, this task has been idle for a while. Please provide an update.

@0x4007
Copy link
Member

0x4007 commented Nov 18, 2024

@rndquu

@YanVictorSN
Copy link
Contributor Author

Hi @rndquu can you assign me on the issue?

@rndquu
Copy link
Member

rndquu commented Dec 13, 2024

@YanVictorSN Could you merge the latest development branch?

@YanVictorSN
Copy link
Contributor Author

YanVictorSN commented Dec 13, 2024

@YanVictorSN Could you merge the latest development branch?

Sure.

@YanVictorSN
Copy link
Contributor Author

YanVictorSN commented Dec 13, 2024

@YanVictorSN Could you merge the latest development branch?

@rndquu I think it's done.

Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YanVictorSN Sorry for a long review, the PR looks good

@rndquu rndquu merged commit 6f3b3e0 into ubiquity:development Dec 13, 2024
11 checks passed
@ubiquity-os ubiquity-os bot mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytics dashboard
3 participants