Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(just): handle non zero exit code update-firmware #169

Merged
merged 1 commit into from
Dec 9, 2023
Merged

fix(just): handle non zero exit code update-firmware #169

merged 1 commit into from
Dec 9, 2023

Conversation

bobslept
Copy link
Contributor

@bobslept bobslept commented Dec 9, 2023

just update-firmware shows an error because of a non zero exit value. That could lead to confusion by the end user. For example:

just update-firmware 
...SNIP...
Devices with the latest available firmware version:
 • UEFI dbx
No updates available
error: Recipe `update-firmware` failed on line 134 with exit code 2

The current PR lets just ignore the exit message on the update-firmware command, so it would not show an error when the exit code is non zero.

Fixes: ublue-os/bluefin#722

@bobslept bobslept enabled auto-merge December 9, 2023 13:40
@bobslept bobslept requested a review from a team December 9, 2023 13:41
@bobslept bobslept added this pull request to the merge queue Dec 9, 2023
Merged via the queue into ublue-os:main with commit 74b4acd Dec 9, 2023
1 check passed
@bobslept bobslept deleted the firmware-upgrade branch December 9, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castrojo castrojo castrojo approved these changes

@p5 p5 p5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Just update-firmware on fresh dx latest
3 participants
@bobslept @castrojo @p5