fix(just): make toggle-updates check if ublue-update is installed #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will now toggle the auto update services relevant for the system depending on ublue-update being present or not.
m2Giles
reviewed
Jun 26, 2024
| sudo systemctl enable --now flatpak-system-update.timer rpm-ostreed-automatic.timer | ||
| systemctl enable --now --user flatpak-user-update.timer | ||
| else | ||
| sudo systemctl enable ublue-update.timer |
There was a problem hiding this comment.
Ublue update is not required to be installed
Its only on Bazzite/bluefin/Aurora.
There was a problem hiding this comment.
Ublue update is not required to be installed
Its only on Bazzite/bluefin/Aurora.
i left it in there because people can still end up installing ublue-update on an image they built from main so it just adapts to that, i know blue-build has ublue-update as a module, so i figured it would just cover for both (since the old code already assumed ublue-update was present by error)
KyleGospo
approved these changes
Jul 24, 2024
m2Giles
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will now toggle the auto update services relevant for the system depending on ublue-update being present or not.
I was originally under the impression that ublue-update was present in main 😅 this is fixed now (and also accounts for people adding ublue-update to their custom main images)