Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the filename for ConditionPathExists on ucore-signed-autorebase.service #226

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

surdy
Copy link
Contributor

@surdy surdy commented Dec 25, 2024

Minor fix on the example autorebase butane file. I think that

ConditionPathExists=!/etc/ucore-autorebase/verified

was intended to be

ConditionPathExists=!/etc/ucore-autorebase/signed

Not a big deal since it won't impact the end result as /etc/ucore-autorebase/verified does not exist as well. But /etc/ucore-autorebase/verified would be "more correct" since that is the file being created on successful run.

I noticed this as I took the example and modified it for my custom ucore image and accidentally introduced a bug in my butane file as a result.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Dec 25, 2024
Copy link
Collaborator

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 9, 2025
@bsherman bsherman enabled auto-merge January 9, 2025 16:30
@bsherman bsherman requested a review from a team January 9, 2025 16:31
@bsherman bsherman added this pull request to the merge queue Jan 9, 2025
Merged via the queue into ublue-os:main with commit 7d3cfad Jan 9, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants