Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(example): monospace text style in _CodeDialog #970

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

TENX-S
Copy link
Contributor

@TENX-S TENX-S commented Dec 18, 2024

Use monospaced style in _CodeDialog to improve readability.

yaru_example_2024_12_18@2x

@Jupi007
Copy link
Member

Jupi007 commented Dec 18, 2024

Great 👍
But maybe should we import the ubuntu mono font into this project directly.
Byw this could be helpful for the datetime picker.
Wdyt @Feichtmeier ?

@TENX-S
Copy link
Contributor Author

TENX-S commented Dec 18, 2024

Please take another look

@Feichtmeier
Copy link
Member

Feichtmeier commented Dec 18, 2024

I think the font adding in the yaru pubspec is enough, the example should then use the font by using the yaru package from path

@Jupi007
Copy link
Member

Jupi007 commented Dec 18, 2024

Yes I think you're right @Feichtmeier

@Feichtmeier Feichtmeier enabled auto-merge (squash) December 19, 2024 09:17
@Feichtmeier Feichtmeier disabled auto-merge December 19, 2024 09:18
@Feichtmeier Feichtmeier enabled auto-merge (squash) December 19, 2024 09:19
@Feichtmeier Feichtmeier merged commit 78397bf into ubuntu:main Dec 19, 2024
7 checks passed
@TENX-S TENX-S deleted the monospace-code-dialog branch December 19, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants