Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump external/pipeline-Nextflow-module from b0b2798 to 9db08f0 #49

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 15, 2024

Bumps external/pipeline-Nextflow-module from b0b2798 to 9db08f0.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from tyamaguchi-ucla as a code owner January 15, 2024 19:07
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 15, 2024
@nwiltsie
Copy link
Member

nwiltsie commented Mar 5, 2024

@dependabot rebase

Bumps [external/pipeline-Nextflow-module](https://github.com/uclahs-cds/pipeline-Nextflow-module) from `b0b2798` to `9db08f0`.
- [Commits](uclahs-cds/pipeline-Nextflow-module@b0b2798...9db08f0)

---
updated-dependencies:
- dependency-name: external/pipeline-Nextflow-module
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/submodules/external/pipeline-Nextflow-module-9db08f0 branch from 5bec247 to 01027dd Compare March 5, 2024 18:18
Copy link
Member

@nwiltsie nwiltsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! The configuration regression tests report no changes, so I think this is good to go!

(The tests don't have full coverage of the configuration process, but these changes also look innocuous.)

@yashpatel6
Copy link
Collaborator

They should be fine though this is a bump in pipeline-Nextflow-module, which typically includes actual nextflow processes so I'm not sure if the config regression tests will cover changes happening in this submodule

@nwiltsie
Copy link
Member

nwiltsie commented Mar 5, 2024

Ah, you're right, I got over-eager. Those won't be covered by these tests.

Copy link
Member

@nwiltsie nwiltsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this should actually be tested... ugh!

@nwiltsie nwiltsie self-assigned this Mar 5, 2024
@nwiltsie
Copy link
Member

nwiltsie commented Mar 5, 2024

Huh. So the first time I tried running NFTest it failed...

$ tail /hot/software/pipeline/pipeline-recalibrate-BAM/Nextflow/development/unreleased/dependabot/submodules/external/pipeline-Nextflow-module-9db08f0/log-nftest-20240305T183817Z.log
2024-03-05 18:51:11,888 - nextflow - main - DEBUG - > Execution complete -- Goodbye
2024-03-05 18:51:12,019 - nftest.syslog - MainThread - DEBUG - Syslog server at 127.0.0.1:40971 shutting down
2024-03-05 18:51:12,940 - NFTest - MainThread - DEBUG - Test creation time: 2024-03-05 18:38:17.812213+00:00
2024-03-05 18:51:12,941 - NFTest - MainThread - DEBUG - Actual mod time:    2024-03-05 18:50:20.955821+00:00
2024-03-05 18:51:12,941 - NFTest - MainThread - DEBUG - md5 /hot/software/pipeline/pipeline-recalibrate-BAM/Nextflow/development/unreleased/dependabot/submodules/external/pipeline-Nextflow-module-9db08f0/A-mini-n2/recalibrate-BAM-1.0.0-rc.4/TWGSAMIN000001/GATK-4.2.4.1/output/BWA-MEM2-2.2.1_GATK-4.2.4.1_A-mini_S2-v1.1.5.bam /hot/software/pipeline/pipeline-recalibrate-BAM/Nextflow/development/output/BWA-MEM2-2.2.1_GATK-4.2.4.1_A-mini_S2-v1.1.5.bam
2024-03-05 18:51:20,963 - NFTest - MainThread - ERROR - Assertion failed
2024-03-05 18:51:20,964 - NFTest - MainThread - ERROR - Actual: /hot/software/pipeline/pipeline-recalibrate-BAM/Nextflow/development/unreleased/dependabot/submodules/external/pipeline-Nextflow-module-9db08f0/A-mini-n2/recalibrate-BAM-1.0.0-rc.4/TWGSAMIN000001/GATK-4.2.4.1/output/BWA-MEM2-2.2.1_GATK-4.2.4.1_A-mini_S2-v1.1.5.bam
2024-03-05 18:51:20,964 - NFTest - MainThread - ERROR - Expect: /hot/software/pipeline/pipeline-recalibrate-BAM/Nextflow/development/output/BWA-MEM2-2.2.1_GATK-4.2.4.1_A-mini_S2-v1.1.5.bam
2024-03-05 18:51:20,964 - NFTest - MainThread - ERROR - ()
2024-03-05 18:51:20,964 - NFTest - MainThread - ERROR -  [ failed ]

... but then after I did various git pulls and git update submodule --init --recursives it worked:

$ tail /hot/software/pipeline/pipeline-recalibrate-BAM/Nextflow/development/unreleased/dependabot/submodules/external/pipeline-Nextflow-module-9db08f0/log-nftest-20240305T195824Z.log
2024-03-05 20:08:50,510 - NFTest - MainThread - DEBUG - Assertion passed
2024-03-05 20:08:50,511 - NFTest - MainThread - DEBUG - Test creation time: 2024-03-05 19:58:24.524466+00:00
2024-03-05 20:08:50,511 - NFTest - MainThread - DEBUG - Actual mod time:    2024-03-05 20:08:35.134379+00:00
2024-03-05 20:08:50,511 - NFTest - MainThread - DEBUG - md5 /hot/software/pipeline/pipeline-recalibrate-BAM/Nextflow/development/unreleased/dependabot/submodules/external/pipeline-Nextflow-module-9db08f0/A-mini-n2/recalibrate-BAM-1.0.0-rc.4/TWGSAMIN000001/GATK-4.2.4.1/output/BWA-MEM2-2.2.1_GATK-4.2.4.1_A-mini_S2-v1.1.5.bam.sha512 /hot/software/pipeline/pipeline-recalibrate-BAM/Nextflow/development/output/BWA-MEM2-2.2.1_GATK-4.2.4.1_A-mini_S2-v1.1.5.bam.sha512
2024-03-05 20:08:50,512 - NFTest - MainThread - DEBUG - Assertion passed
2024-03-05 20:08:50,513 - NFTest - MainThread - DEBUG - Test creation time: 2024-03-05 19:58:24.524472+00:00
2024-03-05 20:08:50,513 - NFTest - MainThread - DEBUG - Actual mod time:    2024-03-05 20:08:35.966003+00:00
2024-03-05 20:08:50,513 - NFTest - MainThread - DEBUG - md5 /hot/software/pipeline/pipeline-recalibrate-BAM/Nextflow/development/unreleased/dependabot/submodules/external/pipeline-Nextflow-module-9db08f0/A-mini-n2/recalibrate-BAM-1.0.0-rc.4/TWGSAMIN000001/GATK-4.2.4.1/output/BWA-MEM2-2.2.1_GATK-4.2.4.1_A-mini_S2-v1.1.5.bam.bai.sha512 /hot/software/pipeline/pipeline-recalibrate-BAM/Nextflow/development/output/BWA-MEM2-2.2.1_GATK-4.2.4.1_A-mini_S2-v1.1.5.bam.bai.sha512
2024-03-05 20:08:50,514 - NFTest - MainThread - DEBUG - Assertion passed
2024-03-05 20:08:50,514 - NFTest - MainThread - INFO -  [ succeed ]

Soooo... I'm somewhat confused, and I can't re-create the original problem I had. Looking back over my terminal output (failed_console.log) it looks like I did all the right things, but something went weird.

@yashpatel6
Copy link
Collaborator

I don't really see anything that would indicate why it would fail the first time... 🤔

Copy link
Collaborator

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with merging this

Copy link
Member

@nwiltsie nwiltsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we should just chalk this up to the SSSD weirdness last week.

@nwiltsie nwiltsie merged commit 75829ae into main Mar 12, 2024
4 checks passed
@nwiltsie nwiltsie deleted the dependabot/submodules/external/pipeline-Nextflow-module-9db08f0 branch March 12, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants