gdc.py: Show error code of failed download request #20
Conversation
|
Yeah, I am working on it. |
Add "test_download_error()" to print the error code on the console. This will print a failure message along with the error code of the network error that happened.
|
As of now, the |
| @@ -69,6 +69,11 @@ def test_download(): | |||
| os.unlink(file_path) | |||
|
|
|||
|
|
|||
| def test_download_error(): | |||
| uuid = "something-invalid-0101" | |||
| gdc.download(uuid) | |||
There was a problem hiding this comment.
Great start! However, you are not asserting the output to some expected output, so the test is not running. You may take a look at the other tests in the same file for some inspiration. 😃
uuid = "something-invalid-0101"
actual = gdc.download(uuid)
expected = <insert the string here>
assert actual == expectedAlso, take a look at the CONTRIBUTING file in #17 .
| @@ -88,3 +93,6 @@ def test_get_samples_clinical(): | |||
| project_id = "TCGA-OV" | |||
| actual = gdc.get_samples_clinical(project_id) | |||
| assert actual['case_id'][0] == "71faa2c1-0d5b-4dcc-bdf9-f2405f29907c" | |||
|
|
|||
|
|
|||
| test_download_error() | |||
There was a problem hiding this comment.
You need not to execute the function. pytest will discover the test and will run by itself.
There was a problem hiding this comment.
Oops, I forgot to remove that part after testing locally, will remove it.
|
@roshnet need a rebase. |
No description provided.