added code to read configurations from a file called .secrets\config.json instead of having to edit the script #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…json instead of having to edit the script
|
Hi @zuhairmahd, this is an excellent Idea. Will have a look on how to implement it based on your PR ASAP. I am going to update this PR as soon as I got time to look into it. Happy holidays to you too 👍 Best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for an incredibly useful script. Rather than having to edit the script, I added a few lines to read the configuration from a json file at $pwd.secrets\config.json. This should even allow you to potentially sign the script since users won't have to edit it to add their tenant configuration.
Thanks again and happy holidays.