Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add live demo url to object page #289

Merged
merged 2 commits into from
Jul 19, 2022
Merged

feat: add live demo url to object page #289

merged 2 commits into from
Jul 19, 2022

Conversation

marianfoo
Copy link
Member

@marianfoo marianfoo commented Jul 19, 2022 •
edited
Loading

Changes

  • with a github workflow we can manually deploy demo apps to a azure statice web app
  • the live demo url can be added to the source.json
  • if a liveDemoUrl is present show this url on object page

What do to if you want to add a sample app

  1. create azure static web app
  2. create subdomain
  3. connect subdomain with azure static web app
  4. add livedemourl to source.json
  5. add build step to create_demo_apps.yml github workflow
  6. run deployment workflow

@marianfoo marianfoo added the enhancement New feature or request label Jul 19, 2022
@marianfoo marianfoo self-assigned this Jul 19, 2022
@marianfoo marianfoo merged commit e674db7 into ui5-community:main Jul 19, 2022
@marianfoo marianfoo mentioned this pull request Jul 19, 2022
Open
@marianfoo marianfoo linked an issue Jul 20, 2022 that may be closed by this pull request
Example App Showcase #256
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marianfoo marianfoo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example App Showcase
1 participant
@marianfoo