-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ska test suite #19
base: main
Are you sure you want to change the base?
Ska test suite #19
Conversation
There is a file test_storage_name.py that I don't see listed in these changes/PR, but which is in the emerlin2caom/tests/ folder after I downloaded this branch, and causes some error when I run python -m test. It looks to be from the CADC side, and calls caom2pipe. Is this one to be moved to a caomdev test suite? |
Resolved in new commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep a cleaner version, I'd prefer the pycache files were removed before a merge (unless they are supposed to be here and I misunderstand), but otherwise the test code runs in test mode with 'pytest', and the code interacts normally with a local database instance, when run in normal mode 'run_script.py', checking for metadata and uploading correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove pycache contents before merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be removed.
Initial unit tests for the e-MERLIN metadata generation code.
Tests can be run from the main directory whilst in your conda environment with the command:
python -m pytest
The unit tests do not currently include mock measurement sets as there were some issues with it being recognised by the python casa module. The best solution is likely to include some small section of a measurement set which can still be read by the code.